Skip to content

fix ci_rustc_if_unchanged_logic test #131434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix ci_rustc_if_unchanged_logic test #131434

merged 1 commit into from
Oct 9, 2024

Conversation

onur-ozkan
Copy link
Contributor

@onur-ozkan onur-ozkan commented Oct 9, 2024 •
edited
Loading

Kind a typo from #122709, which makes ci_rustc_if_unchanged_logic test to fail in any PR that has a change in "library" tree (e.g., #131418 (comment)). This fixes that.

r? ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 9, 2024
@onur-ozkan
Copy link
Contributor Author

@bors r+ p=100

@bors
Copy link
Collaborator

bors commented Oct 9, 2024

📌 Commit 4474018 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2024
@onur-ozkan onur-ozkan mentioned this pull request Oct 9, 2024
Merged
@cuviper cuviper mentioned this pull request Oct 9, 2024
Merged
@bors
Copy link
Collaborator

bors commented Oct 9, 2024

⌛ Testing commit 4474018 with merge 4203c68...

@workingjubilee workingjubilee mentioned this pull request Oct 9, 2024
Closed
@bors
Copy link
Collaborator

bors commented Oct 9, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 4203c68 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2024
@bors bors merged commit 4203c68 into rust-lang:master Oct 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 9, 2024
@onur-ozkan onur-ozkan deleted the fix-if-unchanged-test branch October 9, 2024 07:56
@Zalathar
Copy link
Contributor

Zalathar commented Oct 9, 2024

I think the test might still be failing after this landed: #131438 (comment)

@onur-ozkan
Copy link
Contributor Author

Hmm, I was able to reproduce the previous failures and this change fixed them. Let's wait for #131428 and see what happens.

@Zalathar Zalathar mentioned this pull request Oct 9, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4203c68): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.847s -> 775.672s (-0.02%)
Artifact size: 329.70 MiB -> 329.67 MiB (-0.01%)

@RalfJung RalfJung mentioned this pull request Oct 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @bors @Zalathar @rust-timer @rustbot